Disable mmap in libbacktrace on Apple platforms
#45866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#45731 libbacktrace uses mmap if available to map ranges of the files containing debug information. On macOS `mmap` will succeed even if the mapped range does not exist, and a SIGBUS (with an unusual EXC_BAD_ACCESS code 10) will occur when the program attempts to page in the memory. To combat this we force `libbacktrace` to be built with the simple `read` based fallback on Apple platforms.
kennytm
added
the
S-waiting-on-review
|
@bors: r+ p=1 Thanks for the fix @JohnColanduoni! |
|
📌 Commit 8581b59 has been approved by |
alexcrichton
added
beta-accepted
bors
added a commit
that referenced
this pull request
Nov 8, 2017
Disable `mmap` in `libbacktrace` on Apple platforms Fixes #45731 libbacktrace uses mmap if available to map ranges of the files containing debug information. On macOS `mmap` will succeed even if the mapped range does not exist, and a SIGBUS (with an unusual EXC_BAD_ACCESS code 10) will occur when the program attempts to page in the memory. To combat this we force `libbacktrace` to be built with the simple `read` based fallback on Apple platforms.
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Nov 8, 2017
Mark-Simulacrum
added
beta-nominated
Merged
bors
added a commit
that referenced
this pull request
Nov 13, 2017
Beta next This updates beta Cargo (brings rust-lang/cargo#4716 and rust-lang/cargo#4715), and also includes #45866. This PR also bumps beta to .3 so that we can get a beta release soon.
nikomatsakis
removed
the
beta-nominated
|
Bacported in #45948. |
|
There are no line numbers anymore in the latest nightly. What happened? |
Merged
Aaron1011
added a commit
to Aaron1011/backtrace-rs
that referenced
this pull request
Mar 9, 2020
See rust-lang/rust#45866 for more details
alexcrichton
pushed a commit
to rust-lang/backtrace-rs
that referenced
this pull request
Mar 10, 2020
* Add regression test for SIGPIPE on macOS * Disable `mmap` on macOS See rust-lang/rust#45866 for more details * Run `cargo fmt` * Remove unused variable name * s/macos/darwin/ * Move macOS test to its own file * Move macOS dSYM test to its own directory * Remove 'darwin' check to verify new test * Fix rustfmt * Re-add darwin check * Move macOS test to a non-workspace crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45731
libbacktrace uses mmap if available to map ranges of the files containing debug information. On macOS
mmapwill succeed even if the mapped range does not exist, and a SIGBUS (with an unusual EXC_BAD_ACCESS code 10) will occur when the program attempts to page in the memory. To combat this we forcelibbacktraceto be built with the simplereadbased fallback on Apple platforms.